[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/x4x: Die on unknown memory speed

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33409 )

Change subject: nb/intel/x4x: Die on unknown memory speed
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1: Code-Review-1
> >
> > We still have the same problem when 'u32 speed' is either zero or one.
>
> What's more, since 'u32 speed' is actually an 'enum mem_clock' in both cases 'ddr2mhz(u32 speed)' is called, the 'die()' would never run.

Well, enums in C are weakly typed, so it's possible to assign an enum a value that is not one of the declared enumerations (hence the "very wrong").