Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38593/14/src/mainboard/google/trogd...
File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38593/14/src/mainboard/google/trogd...
PS14, Line 32: gpio_output(GPIO_AMP_ENABLE, 1);
This should be initialized to 0. It will only get changed to 1 by depthcharge once we're actually trying to use the speaker.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I681aa6d0d57671b0fd9b7bc88de6f2cc202a7af0
Gerrit-Change-Number: 38593
Gerrit-PatchSet: 14
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 00:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment