11 Feb
2020
11 Feb
'20
9:54 a.m.
Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 4:
(1 comment)
Replied to comments.
https://review.coreboot.org/c/coreboot/+/38743/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/38743/1/src/northbridge/intel/haswe... PS1, Line 23: ShiftRight (_SB.PCI0.MCHC.DVEN, 3, Local0) : Return (And (Local0, 1))
Still not correct. Correct is […]
Fixed with latest patchset.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38743
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5f089fb6fd774e6c61f4f9281e2945bd44edf27
Gerrit-Change-Number: 38743
Gerrit-PatchSet: 4
Gerrit-Owner: Name of user not set #1002789
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002789
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 11 Feb 2020 15:54:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Name of user not set #1002789
Gerrit-MessageType: comment