Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86013?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in ramstage ......................................................................
Patch Set 2:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86013/comment/8190a5f4_1f74e311?usp... : PS1, Line 9: include
includes
Done
https://review.coreboot.org/c/coreboot/+/86013/comment/5439434b_e559781c?usp... : PS1, Line 9: is a new blob that include
`contains blobs that include` (because we have 2 blobs)
Done
File src/soc/mediatek/common/include/soc/memlayout.h:
https://review.coreboot.org/c/coreboot/+/86013/comment/10e7e42e_a5543939?usp... : PS1, Line 24: #define FSP_INIT_CODE(addr, size) \
I am wrong. The region is served to run the binary. Please ignore my comment.
Done
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86013/comment/321fa64e_940829c0?usp... : PS1, Line 99: FSP_CBFS
`FSP_RAMSTAGE_CBFS`
Done
https://review.coreboot.org/c/coreboot/+/86013/comment/1eb77a81_9948de47?usp... : PS1, Line 104:
No indentation.
Done
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/86013/comment/30df133d_99f19232?usp... : PS1, Line 38: ufs_storage_type
storage_type
Done
https://review.coreboot.org/c/coreboot/+/86013/comment/2876e4ce_c42b33d3?usp... : PS1, Line 40: sizeof(ufs_storage_type), &ufs_storage_type);
move to above line
Done
https://review.coreboot.org/c/coreboot/+/86013/comment/9564e6d6_d1849cbe?usp... : PS1, Line 41: mtk_fsp_load_and_run();
add a blank line below
Done