Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34774 )
Change subject: lib: ramdetect: Register exception handlers for ARMv8 ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34774/9/src/arch/arm64/ramdetect.c File src/arch/arm64/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/9/src/arch/arm64/ramdetect.c@... PS9, Line 38: void
Don't think you need the cast anymore.
Done
https://review.coreboot.org/c/coreboot/+/34774/9/src/include/ramdetect.h File src/include/ramdetect.h:
https://review.coreboot.org/c/coreboot/+/34774/9/src/include/ramdetect.h@22 PS9, Line 22: probe_mb
The doc above is for probe_ramsize, not probe_mb. Add some documentation to probe_mb as well.
Done
https://review.coreboot.org/c/coreboot/+/34774/1/src/lib/ramdetect.c File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/1/src/lib/ramdetect.c@58 PS1, Line 58: probe_mb
Now I don't need to modify probe_ramsize() because of simplifying the type of abort_state. […]
Done
https://review.coreboot.org/c/coreboot/+/34774/3/src/lib/ramdetect.c File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/3/src/lib/ramdetect.c@49 PS3, Line 49: __weak
remove the __weak
Done
https://review.coreboot.org/c/coreboot/+/34774/5/src/lib/ramdetect.c File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/5/src/lib/ramdetect.c@24 PS5, Line 24:
I created 2 versions: […]
I'm using the second solution now.
https://review.coreboot.org/c/coreboot/+/34774/5/src/lib/ramdetect.c@36 PS5, Line 36: =
I believe this if-statement is similar to assert(raw_read_esr_el3() >> 26 == 0x25). […]
Done