Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45012 )
Change subject: soc/intel/common: Add SMRR Lock Supported bit definition for MTRR_CAP
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/msr.h:
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/...
PS1, Line 109: (1<<11)
: #define PRMRR_SUPPORTED (1<<12)
: #define SMRR_LOCK_SUPPORTED (1<<14)
So, this MSR is defined in several places (soc/intel/common & soc/intel/broadwell, as examples), and […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1254fb40c790f2a83dd11c2aabcf9bdf922b9395
Gerrit-Change-Number: 45012
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Sep 2020 01:31:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment