Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45472 )
Change subject: cpu/x86/smm: Add save state ops for different save states
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45472/9/src/cpu/x86/smm/legacy_save...
File src/cpu/x86/smm/legacy_save_state.c:
https://review.coreboot.org/c/coreboot/+/45472/9/src/cpu/x86/smm/legacy_save...
PS9, Line 10: const legacy_smm_state_save_area_t *save_state =
: (const legacy_smm_state_save_area_t *)smm_get_save_state(node);
actually the save state is top aligned to what is allocated.
so save_state = save_state_base + save_state_size - sizeof(struct)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67ab44fbdca5fac5837d32ffda5caad61e534473
Gerrit-Change-Number: 45472
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 01 Nov 2020 21:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment