Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )
Change subject: southbridge/intel/common/smbus.c: Add support for I2C commands
......................................................................
Patch Set 3:
Patch Set 3:
(2 comments)
Patch Set 3:
Ok. I just wanted to be sure about the command format the slave side expects to see.
Unless you really want to, you don't need to rebase your changes. I think it's more valuable if you are available for testing the new code I push.
The trouble here is the lack of symmetry on i2c_block_read() and i2c_block_write(), as they use different command code fields on the host controller.
For sure I'm available for testing code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f8c0f5257a62398189f36892b8159052481693
Gerrit-Change-Number: 30800
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Feb 2019 09:44:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment