Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785...
File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785...
PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrect, but it seems like _ADR is a more specific and useful description of the device than the Plug and Play Hardware ID.
Top level question moved into the source to prevent accidental merging before it's looked at.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id34af26db88b41aff2aa4f3f7b633460d8f4056a
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Sun, 27 Oct 2019 21:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment