Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override if present
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c...
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/45459/36/src/soc/intel/cannonlake/c...
PS36, Line 83: spd_data_ptr
rdev_mmap_full returns a void * […]
variables of type `void *` are very awkward to have on hand... I think either a byte pointer (`const uint8_t *` or `uintptr_t` is appropriate here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 36
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 23 Sep 2020 22:13:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment