Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47417 )
Change subject: mb/google/hatch: Configure IRQs as level triggered for HID over I2C ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... PS2, Line 182: PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, NONE),
No, the signal is passed as is at the pad level and the APIC redirection entry has the right trigger […]
Hm, how does that differ from volteer for example?
src/mainboard/google/volteer/variants/volteer/
gpio: 112 /* E15 : ISH_GP6 ==> TRACKPAD_INT_ODL */ 113 PAD_CFG_GPI_IRQ_WAKE(GPP_E15, NONE, DEEP, LEVEL, INVERT),
dt: 185 chip drivers/i2c/generic 186 register "hid" = ""ELAN0000"" 187 register "desc" = ""ELAN Touchpad"" 188 register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)"