Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46669 )
Change subject: soc/amd/common/acpi: Create platform.asl to define acpi transitions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... File src/soc/amd/common/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... PS2, Line 8: Scope(_SB){
Why does _INI need to go in this scope? We define the method at the root level, so it doesn't seem […]
Yes, it needs to be either _INI under _SB or _INI. I was not sure if _INI at root level works okay or if it needs to be under non-root device. Hence, I suggested adding _SB. With the _SB scope, the method should be just _INI