[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm_module_loader: Drop superfluous checks

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63480 )

Change subject: cpu/x86/smm_module_loader: Drop superfluous checks
......................................................................

Patch Set 23: Code-Review+2

(2 comments)

File src/cpu/x86/smm/smm_module_loader.c:

https://review.coreboot.org/c/coreboot/+/63480/comment/99637e2a_bbe091e4 
PS23, Line 90: 			  const struct smm_loader_params *params)
Callsite looks like:

smm_create_map(smram_base, params->num_concurrent_save_states, params)

Why do we pass num_cpus separately? To me indexing cpus[] would have been more clear written as:

for (i = 1; i < params->num_concurrent_save_states; i++)

https://review.coreboot.org/c/coreboot/+/63480/comment/a9db0906_d2b594a5 
PS23, Line 176: static void smm_place_entry_code(const unsigned int num_cpus)
Not a big deal, I might have just skipped one level:

static void smm_stub_place_staggered_entry_points(
         const struct smm_loader_params *params)
   ...
   for (i = 1; i < params->num_concurrent_save_states; i++)