Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73392 )
Change subject: [WIP]mb/ibm: Add IBM SBP1 ......................................................................
Patch Set 2: Verified-1
(28 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/8877da7e_297a255c PS2, Line 17: 'managment' may be misspelled - perhaps 'management'?
File src/mainboard/ibm/sbp1/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/1195e3e3_de8c3c67 PS2, Line 15: #define PCR_DMI_LPCIOD 0x2770 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/d4ce3a42_b98c2684 PS2, Line 16: #define PCR_DMI_LPCIOE 0x2774 please, no space before tabs
File src/mainboard/ibm/sbp1/include/spr_sbp1_gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/d8f4fb84_28fd3775 PS2, Line 242: _PAD_CFG_STRUCT(GPP_D22, \ Avoid unnecessary line continuations
File src/mainboard/ibm/sbp1/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/b4c0a70f_07d1cab6 PS2, Line 11: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/6b248ce9_b648e100 PS2, Line 13: .SLOTEIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/02949bce_4c5fb612 PS2, Line 15: .SLOTHPSUP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/99873a27_e34710cd PS2, Line 16: .SLOTPIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/62cfc69c_36f72cb9 PS2, Line 17: .SLOTAIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/cda757c8_b3d79320 PS2, Line 18: .SLOTMRLSP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/d5d42ddc_0327956c PS2, Line 19: .SLOTPCP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/a16b0390_d3aa0c6e PS2, Line 20: .SLOTABP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/e56ee025_6b460be8 PS2, Line 21: .SLOTIMP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/4dce3106_38289974 PS2, Line 22: .SLOTSPLS = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/102022a5_729b895d PS2, Line 23: .SLOTSPLV = slotimp ? 25 : 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/00bfb9ff_7f5a7a27 PS2, Line 24: .SLOTPSP = slotpsp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/9366b8eb_f5ff4d3d PS2, Line 25: .VppEnabled = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/e41b2fef_b3dc6201 PS2, Line 26: .VppPort = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/8ed918ab_8a2a63fc PS2, Line 27: .VppAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/aaa72d7b_ed383761 PS2, Line 28: .MuxAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/3a9bba30_1bb77309 PS2, Line 29: .ChannelID = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/c69bf81a_bee86dd2 PS2, Line 30: .PciePortEnable = !pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/68a1b564_c2d13307 PS2, Line 31: .PEXPHIDE = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/3c461970_c7fe73ea PS2, Line 32: .HidePEXPMenu = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/40b9fd23_831a443c PS2, Line 33: .PciePortOwnership = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/44f3060d_6d5d3d0b PS2, Line 34: .RetimerConnectCount = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/ed3b895b_337404d6 PS2, Line 322: UINT8 *DeEmphasisConfig = (UINT8*) deemphasis_list; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171311): https://review.coreboot.org/c/coreboot/+/73392/comment/1e1fb86c_2362a696 PS2, Line 324: for (port = 0; port < CONFIG_MAX_SOCKET * MAX_IIO_PORTS_PER_SOCKET; port++) that open brace { should be on the previous line