Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41849 )
Change subject: cpu/x86/mtrr: add helper for setting multiple MTRRs
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41849/2/src/cpu/x86/mtrr/earlymtrr....
File src/cpu/x86/mtrr/earlymtrr.c:
https://review.coreboot.org/c/coreboot/+/41849/2/src/cpu/x86/mtrr/earlymtrr....
PS2, Line 72: ctx->max_var_mtrrs = get_var_mtrr_count();
Should this call clear_all_var_mtrr() to be sure that we start with no variable MTRRs already set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic03b4b617196f04071093bbba4cf28d23fa482d8
Gerrit-Change-Number: 41849
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 00:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment