Attention is currently required from: Michał Żygowski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68100 )
Change subject: pc80/i8254: Add speaker beep function ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/drivers/pc80/pc/i8254.c:
https://review.coreboot.org/c/coreboot/+/68100/comment/387c2eff_3f9c1942 PS1, Line 7: #include <delay.h> nit: existing includes seem to be sorted alphabetically
https://review.coreboot.org/c/coreboot/+/68100/comment/7b2ddcf0_3599bc77 PS1, Line 129: /* Block for specified miliseconds */
'miliseconds' may be misspelled - perhaps 'milliseconds'?
Please fix.