Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42196 )
Change subject: assert.h: Do not use __FILE__ nor __LINE__ on timeless builds
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42196/1/src/include/assert.h
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/42196/1/src/include/assert.h@7
PS1, Line 7: #include <build.h>
Including <build.h> is always a dependency problem since it is auto-generated. […]
Done
https://review.coreboot.org/c/coreboot/+/42196/1/src/include/assert.h@22
PS1, Line 22: #define __ASSERT_LINE__ __LINE__
Just to be sure, have you double-checked that this still outputs the correct file and line number in […]
I found a better approach: the #line directive.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id42d7121b6864759c042f8e4e438ee77a8ac0b41
Gerrit-Change-Number: 42196
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment