Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 41: /* Call EC _PTS handler */ : _SB.PCI0.LPCB.EC0.PTS (Arg0) I wonder if we should move this into the new MPTS/MWAK too, since that is where the EC is hooked up.
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 44: ( Please add a space between If and ( to keep the style consistent