Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38885 )
Change subject: mb/google/drallion: correct USB3 OC pin configuration
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38885/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38885/2//COMMIT_MSG@7
PS2, Line 7: correct
Correct
https://review.coreboot.org/c/coreboot/+/38885/2//COMMIT_MSG@9
PS2, Line 9: USB3 OC pin was configured wrong pin. Follow HW circuit to set it.
USB3 OC pin is configured for the wrong pin. Follow HW circuit (schematics) to set it correctly.
https://review.coreboot.org/c/coreboot/+/38885/2//COMMIT_MSG@12
PS2, Line 12: is correspond
corresponds
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61234a2054ab52fa508482d3dd0f94b13f96a5c9
Gerrit-Change-Number: 38885
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Feb 2020 12:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment