Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede...
PS6, Line 175: register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
: register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
Is there a 5ms delay required between individual GPIO enables here? In the static ASL file, there was no delay.
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede...
PS6, Line 195: ""\_SB.PCI0.I2C3.CAM1.PRIC""
Why is it relying on CAM1 Power resource when there is no CAM1?
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede...
PS6, Line 200: end
There is no NVM present in this camera module?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f
Gerrit-Change-Number: 45329
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Sep 2020 18:03:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment