Yilin Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45447 )
Change subject: util/rockchip: Port make_idb.py to python3
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45447/6/util/rockchip/make_idb.py
File util/rockchip/make_idb.py:
https://review.coreboot.org/c/coreboot/+/45447/6/util/rockchip/make_idb.py@5...
PS6, Line 53: utf-8
Although in current implementation them seem to always input something you can type (e.g. […]
Done~ I make it throw exception when the length is not 4.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04253084ec9b65310c52598b629390051cd2172b
Gerrit-Change-Number: 45447
Gerrit-PatchSet: 7
Gerrit-Owner: Yilin Yang
kerker@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 10:35:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yilin Yang
kerker@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment