build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )
Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style ......................................................................
Patch Set 8:
(90 comments)
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c File src/device/oprom/x86emu/prim_ops.c:
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 195: if (set_carry) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 295: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@3... PS8, Line 314: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@7... PS8, Line 763: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@7... PS8, Line 784: if (ACCESS_FLAG(F_CF)) { /* carry flag is set */ suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@8... PS8, Line 810: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@8... PS8, Line 815: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@8... PS8, Line 834: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@8... PS8, Line 881: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@8... PS8, Line 886: /* note hackery here. Access_flag(..) evaluates to either line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@9... PS8, Line 945: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@9... PS8, Line 954: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@9... PS8, Line 977: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1024: if ((cnt = s % 8) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1057: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1082: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1122: if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */ do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1153: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1176: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1217: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1217: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1253: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1253: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1286: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1288: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1288: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1321: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1323: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1323: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1356: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1358: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1358: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1358: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1358: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1390: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1392: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1392: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1422: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1460: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1498: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1541: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1541: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1574: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1576: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1576: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1609: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1611: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1611: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1643: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1645: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1645: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1645: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1645: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1668: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1670: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1670: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1670: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1670: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1692: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1694: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1694: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1694: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1694: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1716: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1718: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1718: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1718: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1718: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1934: if ((d_sign = d & 0x80000000) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1934: if ((d_sign = d & 0x80000000) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1939: if ((s_sign = s & 0x80000000) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1... PS8, Line 1939: if ((s_sign = s & 0x80000000) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2304: } else if (size == 2) { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2304: } else if (size == 2) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2304: } else if (size == 2) { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2307: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2307: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2307: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2317: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2352: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2352: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2352: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2362: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2375: if (M.x86.mode & SYSMODE_32BIT_REP) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2471: /* Regardless if we have real data from the hardware, the emulator line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2472: * will only support upto feature 1, which we set in register EAX. line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2482: /* If we don't have x86 compatible hardware, we return values from an line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2483: * Intel 486dx4; which was one of the first processors to have CPUID. line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2489: /* In the case that we have hardware CPUID instruction, we make sure line over 80 characters
https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2... PS8, Line 2496: * return all zeros when queried for invalid or unsupported feature line over 80 characters