[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Add ADL-P romstage mainboard code

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )

Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... 
File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/46091/7/src/mainboard/intel/adlrvp/... 
PS7, Line 8: register "SaGv" = "SaGv_Disabled"
> Sorry, I don't mean the FSP default, I mean the devicetree default; if you don't set the `SaGv` regi […]

Ah, hrm. Couldn't SaGv be controlled by Kconfig, though? If SaGv doesn't have any mainboard-specific requirements, it would be good if it were a Kconfig option.

I usually want to set SaGv to FixedHigh to improve boot times when testing stuff, but would want to use Enabled to get better battery life. Having to patch the devicetree to do so is annoying.