[coreboot-gerrit] [S] Change in coreboot[main]: spi: Move block protection bits to new struct spi_flash_bpbits

[Jakub Czapiga (Code Review)]

Attention is currently required from: Daniel Gröber, Daniel Gröber (dxld), Julius Werner.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42112?usp=email )

Change subject: spi: Move block protection bits to new struct spi_flash_bpbits
......................................................................

Patch Set 25:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/42112/comment/37cba46f_497fdb5d :
PS24, Line 7: ove block protection bits to new struct spi_flash_bpbits
This patch does not actually move mentioned values, but only creates new struct for them. Please adjust commit message accordingly.

File src/include/spi_flash.h:

https://review.coreboot.org/c/coreboot/+/42112/comment/08512c65_549ef041 :
PS24, Line 53: bp
nit: I think it would be better to use more descriptive field names when possible. Applies to `bp`, `cmp` and `tb`.

https://review.coreboot.org/c/coreboot/+/42112/comment/a0f5ee91_b45e0108 :
PS24, Line 56: union {
Is this union necessary?