Attention is currently required from: Daniel Gröber, Daniel Gröber (dxld), Julius Werner.
3 comments:
Commit Message:
Patch Set #24, Line 7: ove block protection bits to new struct spi_flash_bpbits
This patch does not actually move mentioned values, but only creates new struct for them. Please adjust commit message accordingly.
File src/include/spi_flash.h:
nit: I think it would be better to use more descriptive field names when possible. Applies to `bp`, `cmp` and `tb`.
Patch Set #24, Line 56: union {
Is this union necessary?
To view, visit change 42112. To unsubscribe, or for help writing mail filters, visit settings.