Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: src: Move vendorcode menu from chipset to last menu
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Makes sense but I don't know the reasons why it was placed
in Chipset. Also, why does vendorcode have visible options?
I have no clue why it was in chipset.
We have visible options as the eltan security features need configuration. This menu however will only be visible if the option is selected on board level. So it will only show up when supported by the board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b2aa3836e8d9a3242c6d1f3ba7b7821a5cfb9d3
Gerrit-Change-Number: 36851
Gerrit-PatchSet: 1
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 15:51:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment