Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40334 )
Change subject: configs: Add builder config to create a working Sonora Pass
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40334/8/configs/builder/config.ocp....
File configs/builder/config.ocp.sonorapass:
https://review.coreboot.org/c/coreboot/+/40334/8/configs/builder/config.ocp....
PS8, Line 21: earlyprintk=uart8250,io,0x3f8
please note: this syntax is not correct. This is extremely confusing, and must be fixed. […]
coreboot uses 115200 by default, wouldn't it make more sense to use the same value for earlyprintk? Or is this a different UART than the one used for coreboot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60452205d666fd19582780401ccd9d7773e68a5b
Gerrit-Change-Number: 40334
Gerrit-PatchSet: 8
Gerrit-Owner: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Apr 2020 18:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment