Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/msr.h
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/msr.h@...
PS17, Line 36: (1<<0)
Really? This escaped review? Also, note that defines for bits within a register are indented with an […]
Corrected in #37821 patch set 2
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h@...
PS17, Line 69: u32 start32_offset;
They might also be breaking Werner's APL boards because of the increased size.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b8e68b2928aefc7996b6a9560c52f71c7c0e1d0
Gerrit-Change-Number: 33985
Gerrit-PatchSet: 17
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 19 Dec 2019 15:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment