Attention is currently required from: Bao Zheng.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69045 )
Change subject: amdfwtool: Add entry types required to support glinda & phoenix SOC
......................................................................
Patch Set 17:
(2 comments)
File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/69045/comment/90750d36_a4d69221
PS9, Line 71: AMD_FW_TPMLITE = 0x5f,
: AMD_FW_PSP_SMUSCS = 0x5f,
Done
added a comment in CB:72713
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/69045/comment/92fc7227_9d763662
PS9, Line 281: else if (strcmp(fw_name, "RIB_FILE") == 0) {
: fw_type = AMD_RIB;
: subprog = 0;
: }
{ .type = AMD_RIB, .subprog = 0, .level = PSP_LVL2 | PSP_LVL2_AB }, […]
added in CB:72507
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f
Gerrit-Change-Number: 69045
Gerrit-PatchSet: 17
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Comment-Date: Sat, 04 Feb 2023 03:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: ritul guru
ritul.bits@gmail.com
Gerrit-MessageType: comment