Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790
......................................................................
Patch Set 54:
(3 comments)
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@11
PS54, Line 11: There are (at least) three different mainboards:
say for which of these boards this patch adds support
Ack
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@21
PS54, Line 21: This port has been tested with: USFF
what is with the Minitower variant?
I can test this later, but not right now.
https://review.coreboot.org/#/c/21774/45/src/mainboard/dell/optiplex_790/mai...
File src/mainboard/dell/optiplex_790/mainboard.c:
https://review.coreboot.org/#/c/21774/45/src/mainboard/dell/optiplex_790/mai...
PS45, Line 24:
Remove blank line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 54
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johanna Schander
coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 05 Jun 2019 14:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment