Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33370 )
Change subject: mb/google/octopus: default DRAM_PART_NUM_IN_CBI to y
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33370/1/src/mainboard/google/octopus/Kconfig
File src/mainboard/google/octopus/Kconfig:
https://review.coreboot.org/#/c/33370/1/src/mainboard/google/octopus/Kconfig...
PS1, Line 138: DRAM_PART_NUM_ALWAYS_IN_CBI
Just wondering if we can remove this config item altogether since we are checking only for NOT_ALWAYS_IN_CBI in the rest of the code and we have defined it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb136aa960260abe1657b16ded02a7dfb63c6849
Gerrit-Change-Number: 33370
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Jun 2019 17:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment