Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )
Change subject: volteer: Create halvor variant ......................................................................
Patch Set 7: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/Makefile.inc:
PS7: Please use SPDX:
## SPDX-License-Identifier: GPL-2.0-only ## This file is part of the coreboot project.
https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... PS7, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 Google LLC : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/include/variant/ec.h:
PS7: Please use SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h:
PS7: Please use SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */