Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32326 )
Change subject: kohaku: mb/hatch/gpio: Scrub Kohaku GPIOs.
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32326/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/#/c/32326/2/src/mainboard/google/hatch/variants/...
PS2, Line 46: PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, INVERT),
The comment above does not agree with the code
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5c83a0538d367ea11e9499f21cea41891d7a78e
Gerrit-Change-Number: 32326
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment