Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... PS7, Line 294: const
Why const?
Left over from an earlier version of the patch. Removed.
https://review.coreboot.org/c/coreboot/+/47308/6/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/6/src/mainboard/google/zork/v... PS6, Line 304: if (google_chromeec_cbi_get_board_version(&board_version)) : board_version = 1; :
This reads board version but doesn't do anything with it. […]
No, this one should have been removed.
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... PS7, Line 302: )
I think this should be done only when slp_typ is not ACPI_S3?
Done
https://review.coreboot.org/c/coreboot/+/47308/10/src/mainboard/google/zork/... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/47308/10/src/mainboard/google/zork/... PS10, Line 83: of
if
Done
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/47308/7/src/mainboard/google/zork/v... PS7, Line 29: powering on because of reset, powering on, or resuming from S3
That is the case for all GPIOs, right? Probably add GPIOs that need to be configured early on in boo […]
Ack