Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43957 )
Change subject: soc/mediatek/mt8192: Initial commit
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG@7
PS1, Line 7: soc/mediatek/mt8192: Initial commit
Please make it a statement by adding a verb (in imperative mood). Maybe:
soc/mediatek/mt8192: Add new ARMv8 device MT8192
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG@10
PS1, Line 10:
Please give more details about the device. Is it similar to an already support device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e34c03a11a77ed98674ffd8eeddb20ef5fea89d
Gerrit-Change-Number: 43957
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jul 2020 06:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment