Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36137 )
Change subject: soc/intel: skl,cnl,icl: consolidate ebda and memmap
......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36137/19/src/soc/intel/common/block...
File src/soc/intel/common/block/memmap/memmap.c:
https://review.coreboot.org/c/coreboot/+/36137/19/src/soc/intel/common/block...
PS19, Line 40: also maps into MC address space
nope :/
MC = memory controller ... does that have to do with remapping?
From src/northbridge/intel/x4x/northbridge.c:
111 * If >= 4GB installed then memory from TOLUD to 4GB
112 * is remapped above TOM, TOUUD will account for both
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a20c814d2a6874fcb4ff99ef1a7825d891f74e2
Gerrit-Change-Number: 36137
Gerrit-PatchSet: 23
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Oct 2019 15:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment