build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: mb/acer: add Aspire ES1-572 and Extensa 2540 (Compal LA-E061P) ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38978/10/src/mainboard/acer/es1-572... File src/mainboard/acer/es1-572/gpio.c:
https://review.coreboot.org/c/coreboot/+/38978/10/src/mainboard/acer/es1-572... PS10, Line 131: PAD_CFG_GPI_SCI_LOW(GPP_E16, UP_20K, DEEP, LEVEL),/* GPP_E16 / EC_SCI# */ // TODO SMI? smihandler line over 96 characters
https://review.coreboot.org/c/coreboot/+/38978/10/src/mainboard/acer/es1-572... File src/mainboard/acer/es1-572/romstage.c:
https://review.coreboot.org/c/coreboot/+/38978/10/src/mainboard/acer/es1-572... PS10, Line 20: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/38978/10/src/mainboard/acer/es1-572... PS10, Line 21: FSP_M_TEST_CONFIG *const test_cfg = &mupd->FspmTestConfig; need consistent spacing around '*' (ctx:WxV)