[coreboot-gerrit] [M] Change in coreboot[main]: amdfwtool: Move the header creation into integration function

[Felix Held (Code Review)]

Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81253?usp=email )

Change subject: amdfwtool: Move the header creation into integration function
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/81253/comment/442e1836_4db90473 :
PS2, Line 963: 	else if (ctx->pspdir2_b == NULL)
i'd use else if (cookie == PSPL2_COOKIE && ctx->pspdir2_b == NULL) to properly handle the case of an unexpected cookie value

https://review.coreboot.org/c/coreboot/+/81253/comment/66643912_50c8f602 :
PS2, Line 1260: 	else if (ctx->biosdir2_b == NULL)
i'd check for cookie == BHDL2_COOKIE && ctx->biosdir2_b == NULL to also cover the case of an unexpected cookie value