Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31672 )
Change subject: sb/intel/i82801gx: Remove unnecessary/redundant ACPI offset operator ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/31672/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31672/4//COMMIT_MSG@9 PS4, Line 9: detect detects
https://review.coreboot.org/#/c/31672/4//COMMIT_MSG@11 PS4, Line 11: send sends
https://review.coreboot.org/#/c/31672/4//COMMIT_MSG@11 PS4, Line 11: it It
https://review.coreboot.org/#/c/31672/4//COMMIT_MSG@8 PS4, Line 8: : IASL detect Unnecessary/redundant uses of the Offset() operator within : a Field Unit list. : it then send a remark "^ Unnecessary/redundant use of Offset" : : example: : OperationRegion (OPR1, SystemMemory, 0x100, 0x100) : Field (OPR1) : { : Offset (0), // Never needed : FLD1, 32, : Offset (4), // Redundant, offset is already 4 (bytes) : FLD2, 8, : Offset (64), // OK use of Offset. : FLD3, 16, : } : : We will have those remark: : dsdt.asl 14: Offset (0), : Remark 2158 - ^ Unnecessary/redundant use of Offset : operator : : dsdt.asl 16: Offset (4), : Remark 2158 - ^ Unnecessary/redundant use of Offset : operator Thank you for adding more details, but do you know why these offsets were added in the first place?