Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/...
File src/soc/intel/common/block/fast_spi/mmap_boot.c:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/...
PS9, Line 115: ext_win_size
one thing that might be nice as I was trying these patches is to see some console output indicating the windows that end up getting used. I'm not sure here is the right place since this function ends up getting called for every stage and we don't necessarily need the same output 4 times in one boot...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b564aed9809cf14b40a3b8e907622266fc782e2
Gerrit-Change-Number: 47659
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 23:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment