Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36318 )
Change subject: {northbridge,soc,southbridge}: Don't use both of _ADR and _HID
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36318/13/src/northbridge/amd/agesa/...
File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/36318/13/src/northbridge/amd/agesa/...
PS13, Line 21: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
This looks like the address of a device on the bus not like the bus.
Exactly. Fix available in CB:37835
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb777c09aeef09a6a4cbee254b081519f5b6c457
Gerrit-Change-Number: 36318
Gerrit-PatchSet: 13
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 19 Dec 2019 12:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment