16 May
2019
16 May
'19
6:59 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )
Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32788/8/src/soc/intel/common/block/gpio/gpio... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/32788/8/src/soc/intel/common/block/gpio/gpio... PS8, Line 614: uint8_t *misccfg_pm_value Would prefer to see this const uint8_t *misccfg_pm_values
--
To view, visit https://review.coreboot.org/c/coreboot/+/32788
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I816a70ad92595f013740a235a9799912ad51665e
Gerrit-Change-Number: 32788
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Comment-Date: Thu, 16 May 2019 16:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment