[coreboot-gerrit] Change in coreboot[master]: ec/kontron: Fix control flow DEADCODE issue

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )

Change subject: ec/kontron: Fix control flow DEADCODE issue
......................................................................

Patch Set 4:

(1 comment)
> Patch Set 4:
>
> (1 comment)
>
> Please never remove checks because of tools.

Instead, try to find a more suitable kind of check.

https://review.coreboot.org/c/coreboot/+/45623/4/src/ec/kontron/kempld/kempl... 
File src/ec/kontron/kempld/kempld_i2c.c:

https://review.coreboot.org/c/coreboot/+/45623/4/src/ec/kontron/kempld/kempl... 
PS4, Line 253: 	if (prescale < 0)
> I guess I kept it in case the constants would change (it is probably runtime […]

Sounds good. Regular `assert()` now provides compile-time checks if possible, too.