Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39828 )
Change subject: sb/intel/bd82x6x: Add legacy mode support to SATA
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39828/2/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/sata.c:
https://review.coreboot.org/c/coreboot/+/39828/2/src/southbridge/intel/bd82x...
PS2, Line 143: pci_or_config8(dev, 0x09, 0x05);
is that register documented?
if so could you please use define for that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e7a4befa02772f620602fa2a92c3583895d4d1c
Gerrit-Change-Number: 39828
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 08:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment