Attention is currently required from: jitao shi.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/907e6a44_a093afd8
PS2, Line 207: 10
According to https://patchwork.kernel.org/project/linux-mediatek/patch/20210201033603.126.... […]
I'm also super confused by this. The MIPI_DSI_MODE_EOT_PACKET flag has been modified multiple times.
CB:41161 added the flag for anx7625.
+ if (CONFIG(DRIVER_ANALOGIX_ANX7625))
+ mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;
CB:48868 further added
+ if (mode_flags & MIPI_DSI_MODE_EOT_PACKET)
+ delta += 2;
However, CL:2604806 in kernel removed MIPI_DSI_MODE_EOT_PACKET for anx7625. Should we also *enable* EOTP (by removing the flag) in coreboot too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 6
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Attention: jitao shi
jitao.shi@mediatek.com
Gerrit-Comment-Date: Fri, 09 Apr 2021 08:39:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@google.com
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@chromium.org
Comment-In-Reply-To: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-MessageType: comment