Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45833 )
Change subject: soc/intel/xeon_sp: Clean up pci_devs.h ......................................................................
Patch Set 4:
(3 comments)
I'd rather not block this patch train with things that can be done in a follow-up
https://review.coreboot.org/c/coreboot/+/45833/3/src/soc/intel/xeon_sp/skx/i... File src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/45833/3/src/soc/intel/xeon_sp/skx/i... PS3, Line 57: BIT
<types. […]
Can be handled later once skx and cpx are unified.
https://review.coreboot.org/c/coreboot/+/45833/3/src/soc/intel/xeon_sp/skx/i... PS3, Line 57:
why not tabs?
Can be handled later once skx and cpx are unified.
https://review.coreboot.org/c/coreboot/+/45833/3/src/soc/intel/xeon_sp/skx/i... PS3, Line 71:
tabs?
Can be handled later once skx and cpx are unified.