KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: src: cast *cbmem_top_chipset() function to uintptr_t ......................................................................
Patch Set 20:
(6 comments)
Everything that you have advice is up to date ...
please review all my changes ...
https://review.coreboot.org/c/coreboot/+/43756/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43756/15//COMMIT_MSG@7 PS15, Line 7: src:cast
Please add a space after the colon (:).
Done
https://review.coreboot.org/c/coreboot/+/43756/18/src/include/cbmem.h File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/43756/18/src/include/cbmem.h@60 PS18, Line 60: uintptr_t cbmem_top(void)
maybe in an other changes?
Done
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c@22 PS18, Line 22: static void *top;
Just change top's type.
Done
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c@29 PS18, Line 29: return (uintptr_t)_cbmem_top_ptr;
cast not needed
Done
https://review.coreboot.org/c/coreboot/+/43756/18/src/northbridge/intel/x4x/... File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/43756/18/src/northbridge/intel/x4x/... PS18, Line 5: #include <stdint.h>
duplicated
Done
https://review.coreboot.org/c/coreboot/+/43756/18/src/northbridge/intel/x4x/... PS18, Line 8: <stdint.h>
here is the 2nd
Done