Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46437 )
Change subject: mb/google/volteer: New variant for Volteer reworked with Dauntless ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/46437/6/src/mainboard/google/voltee... PS6, Line 140: volteer2_ti50
I am surprised though, that I do not see any similar declaration in the SPI section of the existing Volteer devicetree.
It is present in baseboard/devicetree: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/volt...
I have left it out for now, since for now we will be happy to get coreboot to communicate with the new Dauntless chip, then we can worry about the kernel later.
Okay. You will require some work at runtime to disable touchscreen nodes and enable the one for TPM for volteer2_ti50.
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer2/gpio.c:
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... PS10, Line 249: UP_2K Why UP_2K here and for SCL below?
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... PS10, Line 23: register "common_soc_config.gspi[0].early_init" = "CONFIG(MAINBOARD_HAS_SPI_TPM_CR50)" : register "common_soc_config.i2c[1].early_init" = "CONFIG(MAINBOARD_HAS_I2C_TPM_CR50)" Did these work correctly for overriding the early_init configs? I remember there was some expectation in sconfig that you need to duplicate the entire common_soc_config in overridetree to ensure it gets overridden correctly. Did you check the generated static.c files for volteer2 and volteer2_ti50 to make sure they look as expected?