Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40911 )
Change subject: mb/purism/librem_skl: Convert to use override devicetree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40911/2/src/mainboard/purism/librem...
File src/mainboard/purism/librem_skl/variants/librem15v3/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40911/2/src/mainboard/purism/librem...
PS2, Line 3: # Enable CLKREQ# for RP9
: register "PcieRpClkReqSupport[8]" = "0"
: # ClkReq for NVMe - Bruteforced (no other value works)
: register "PcieRpClkReqNumber[8]" = "2"
good catch, I'll try enabling and if no-go then remove the ClkReq and adjust the comment
addressed in CB:40950
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dac62a649e12ea2498d3ecafe03fd0d62af5f2b
Gerrit-Change-Number: 40911
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 18:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment
