Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d...
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d...
PS1, Line 141: PIN_CFG_NC
Actually, please below `AZALIA_PIN_CFG` and add `AZALIA_` prefix.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I740d0d756599688165458a9c6e925d5d94754bb2
Gerrit-Change-Number: 45604
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 13:10:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment